-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repo-updater: Add readinessProbe #816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might want to make sure we update the image here too
@bobheadxi Yep, I will not merge that until the image is released, I created the PR so I could link it to the other one and show what I'm changing. |
Rerunning tests, as the old tests ran with the old image. I have also verified this locally and probes work correctly. Hopefully this will reduce the deployment downtime for this service. |
Due to our tests using the currently released image, we will wait for 3.19 to be released which includes the change that fixes this PR. |
0252dd9
to
b785fff
Compare
commit 0415290 Author: Gonzalo Peci <pecigonzalo@users.noreply.github.com> Date: Fri Aug 21 13:56:08 2020 +0200 repo-updater: Add readinessProbe (#816) * repo-updater: Add readinessProbe * fixup! repo-updater: Add readinessProbe commit 2b33c8c Author: uwedeportivo <534011+uwedeportivo@users.noreply.github.com> Date: Thu Aug 20 20:49:41 2020 -0700 up grafana to 3.19.1 (#833) commit cc3fdc1 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Aug 20 20:32:53 2020 -0700 Update index.docker.io/sourcegraph/prometheus Docker tag to v3.19.1 (#830) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 4a55ae6 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Thu Aug 20 20:28:47 2020 -0700 Update Sourcegraph Docker images Docker tags to v3.19.1 (#832) Co-authored-by: Renovate Bot <bot@renovateapp.com> commit 04cab68 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Fri Aug 21 01:51:50 2020 +0000 Update Sourcegraph Docker images Docker tags to v3.19.1-rc.2 (#829) Co-authored-by: Renovate Bot <bot@renovateapp.com>
* repo-updater: Add readinessProbe * fixup! repo-updater: Add readinessProbe
We currently dont have any checks to ensure
repo-updater
is ready before tearing down its old deployment, but we useRollingUpdate
for its upgrades. This sometimes causes downtime as the new pod is started but unable to serve traffic yet.It should also help fix/reduce the alerts regarding
repo-updater
downtime as a result.Notes
Requires: https://github.com/sourcegraph/sourcegraph/pull/12880